]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
st-icon: check if gicon is null before unref.
authorAlban Browaeys <prahal@yahoo.com>
Thu, 25 Apr 2013 16:25:12 +0000 (18:25 +0200)
committerAdel Gadllah <adel.gadllah@gmail.com>
Thu, 2 May 2013 07:51:32 +0000 (09:51 +0200)
Commit a6b49fe7d6c9bcd8a2be47a0b0b44cf9a53a45aa
introduced a check for equality of priv->gicon vs gicon
and unref then return early if so. But if both are null,
we should not unref gicon. Only return.

https://bugzilla.gnome.org/show_bug.cgi?id=698863

src/st/st-icon.c

index b29744b64139e3fdab08a79d117460a80e478eda..3fec7e2a28a1d0979e5350fe059f933b52404207 100644 (file)
@@ -544,7 +544,8 @@ st_icon_set_icon_name (StIcon      *icon,
 
   if (g_icon_equal (priv->gicon, gicon)) /* do nothing */
     {
-      g_object_unref (gicon);
+      if (gicon)
+        g_object_unref (gicon);
       return;
     }